[Fixed] SVN: Non-admin given option to change admin panel layout

FWishbringer

Member

Offline

Posts: 46

SVN: Non-admin given option to change admin panel layout
Posted on: 16th September, 2009, 06:53:46 PM

In the file LayoutsEditProfile.php, the line...

Code:

$body = theme('title', $EDITPROFILE_LANG["theme_title"]) . theme('start_content') . '<div id="editprofileLinks" class="editprofile-links" align="center">[ <a id="editAccLink" class="text-link editprofile-link editprofile-account-link" href="'.$settings['site_url'].'/index.php?act=editaccount">' . str_replace(' ',' ',$EDITPROFILE_LANG["account_settings"]) . '</a> ] [ <a id="editMiscLink" class="text-link editprofile-link editprofile-misc-link" href="'.$settings['site_url'].'/index.php?act=editmiscellaneous">' . str_replace(' ',' ',$EDITPROFILE_LANG["misc_settings"]) . '</a> ] [ <a id="editLookLink" class="text-link editprofile-link editprofile-look-link" href="'.$settings['site_url'].'/index.php?act=editlook">' . str_replace(' ',' ',$EDITPROFILE_LANG["look_settings"]) . '</a> ]'.($user['admin_panel'] ? ' [ <a id="editAdminLink" class="text-link editprofile-link editprofile-admin-link" href="'.$settings['site_url'].'/index.php?act=userpreferances">' . str_replace(' ',' ',$EDITPROFILE_LANG["user_settings"]) . '</a> ]' : '').'</div>';

...has this little bit here...

Code:

($user['admin_panel'] ? ' [ <a id="editAdminLink" class="text-link editprofile-link editprofile-admin-link" href="'.$settings['site_url'].'/index.php?act=userpreferances">' . str_replace(' ',' ',$EDITPROFILE_LANG["user_settings"]) . '</a> ]' : '')

...which looks like it's only supposed to display if the user has access to the admin panel.

Upon creating a new user, and setting them as a "member" (sendmail isn't working, haven't looked into it yet) the member can see this in the edit profile page. If I read right, the idea is, only admins can see it.

My fix? I made my own admin panel layout, so simply removed it.

For readability purposes, may want to look into breaking that line up... a 1175 character line makes for slightly more difficult tweaking.

Last Edit: 16th September, 2009, 06:54:08 PM by FWishbringer

confuser

eoCMS Developer

Offline

Posts: 1528

Re: SVN: Non-admin given option to change admin panel layout
Posted on: 19th September, 2009, 02:45:17 PM

Could you test to make sure the "member" cant access the admin panel? Dont forget to include the authid in the URL when testing Wink

Because if it shows that, then that means admin_panel is set to true

Please do not PM me requesting support or anything, use the forums, thats what they are here for

confuser eoCMS Developer Offline Posts: 1528	Re: SVN: Non-admin given option to change admin panel layout Posted on: 23rd January, 2010, 11:13:50 AM TGPEG mark as fixed please Please do not PM me requesting support or anything, use the forums, thats what they are here for

TGPEG eoCMS Designer Offline Posts: 1290	Re: SVN: Non-admin given option to change admin panel layout Posted on: 24th January, 2010, 04:50:56 AM This bug has been deemed [Fixed] by an eoCMS developer. If you dispute the Fix, please PM a developer, giving details of why. This topic can then be unlocked allowing for further discussion. Seen a bug? Report it!

Jump to:

Page 1 Of 1

Username:
Password:
Remember me??

[ Register ][ Forgot Password? ]